Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pluginsWithPermission information #2213

Merged

Conversation

dzemanov
Copy link
Contributor

@dzemanov dzemanov commented Dec 19, 2024

Hey, I just made a Pull Request!

It would be useful to add information about configuring pluginsWithPermission in app-config.yaml since without it, available permissions will not be displayed by RBAC UI.

Fixes

RHIDP-4490

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@dzemanov dzemanov requested review from christoph-jerolimov and a team as code owners December 19, 2024 14:04
@dzemanov dzemanov requested a review from BethGriggs December 19, 2024 14:04
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Dec 19, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-rbac-backend workspaces/rbac/plugins/rbac-backend patch v5.2.8
@backstage-community/plugin-rbac workspaces/rbac/plugins/rbac patch v1.33.5

@dzemanov dzemanov force-pushed the rbac-docs-pluginsWithPermission branch 2 times, most recently from fe19780 to 681c953 Compare December 20, 2024 09:12
@dzemanov dzemanov force-pushed the rbac-docs-pluginsWithPermission branch from 77e6a52 to fe6be2a Compare December 20, 2024 12:49
@dzemanov dzemanov force-pushed the rbac-docs-pluginsWithPermission branch 2 times, most recently from dbdde16 to 9cea829 Compare January 2, 2025 15:54
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this PR, but I have two recommendations:

workspaces/rbac/plugins/rbac-backend/README.md Outdated Show resolved Hide resolved
workspaces/rbac/plugins/rbac/README.md Outdated Show resolved Hide resolved
Signed-off-by: Dominika Zemanovicova <[email protected]>
Signed-off-by: Dominika Zemanovicova <[email protected]>
Signed-off-by: Dominika Zemanovicova <[email protected]>
Signed-off-by: Dominika Zemanovicova <[email protected]>
Co-authored-by: <[email protected]>
Signed-off-by: Dominika Zemanovicova <[email protected]>
@dzemanov dzemanov force-pushed the rbac-docs-pluginsWithPermission branch from ce95138 to 7f7c4a9 Compare January 3, 2025 09:03
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Lgtm! 👍

@christoph-jerolimov christoph-jerolimov merged commit 5b19b0d into backstage:main Jan 3, 2025
11 checks passed
@dzemanov dzemanov deleted the rbac-docs-pluginsWithPermission branch January 6, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants