-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce pluginsWithPermission
information
#2213
Merged
christoph-jerolimov
merged 5 commits into
backstage:main
from
dzemanov:rbac-docs-pluginsWithPermission
Jan 3, 2025
Merged
Introduce pluginsWithPermission
information
#2213
christoph-jerolimov
merged 5 commits into
backstage:main
from
dzemanov:rbac-docs-pluginsWithPermission
Jan 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzemanov
requested review from
christoph-jerolimov and
a team
as code owners
December 19, 2024 14:04
Changed Packages
|
dzemanov
force-pushed
the
rbac-docs-pluginsWithPermission
branch
2 times, most recently
from
December 20, 2024 09:12
fe19780
to
681c953
Compare
AndrienkoAleksandr
approved these changes
Dec 20, 2024
dzemanov
force-pushed
the
rbac-docs-pluginsWithPermission
branch
from
December 20, 2024 12:49
77e6a52
to
fe6be2a
Compare
dzemanov
force-pushed
the
rbac-docs-pluginsWithPermission
branch
2 times, most recently
from
January 2, 2025 15:54
dbdde16
to
9cea829
Compare
04kash
approved these changes
Jan 2, 2025
christoph-jerolimov
requested changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on this PR, but I have two recommendations:
Signed-off-by: Dominika Zemanovicova <[email protected]>
Signed-off-by: Dominika Zemanovicova <[email protected]>
Signed-off-by: Dominika Zemanovicova <[email protected]>
Signed-off-by: Dominika Zemanovicova <[email protected]>
Co-authored-by: <[email protected]> Signed-off-by: Dominika Zemanovicova <[email protected]>
dzemanov
force-pushed
the
rbac-docs-pluginsWithPermission
branch
from
January 3, 2025 09:03
ce95138
to
7f7c4a9
Compare
christoph-jerolimov
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Lgtm! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
It would be useful to add information about configuring
pluginsWithPermission
inapp-config.yaml
since without it, available permissions will not be displayed by RBAC UI.Fixes
RHIDP-4490
✔️ Checklist
Signed-off-by
line in the message. (more info)